Final review - Githubissues

riparias / union-list

List of Invasive Alien Species of Union concern

https://riparias.github.io/union-list/

MIT License

0 stars 0 forks source link

Final review #13

Closed damianooldoni closed 1 year ago

damianooldoni commented 1 year ago

To be reviewed:

[x] the dates in field entry_into_force in raw data (tsv file) some are in the future, e.g. for Celastrus orbiculatus is this field set to 2027-08-02, while for Fundulus heteroclitus andXenopus laevis is 2024-08-02. I see also that in 2022 we have two very near dates: 2022-07-12 and 2022-08-02. Maybe is correct, but still worth a final check
[x] the link to the most actual consolidated pdf version (I modified the link to point the 2022 list, please @timadriaens double check this) in Workflow section of README.
[x] The webpage with English common names is outdated. I couldn't find any other similar webpage. The only link with common names is the PDF brochure to download on circabc but I don't find it good enough.
[x] metadata. I went through the document and seems good, but still, @timadriaens, we need a sentence mentioning the issues encountered while harvesting data from EASIN API, see #9 (+ #10), I think, to justify our approach.

timadriaens commented 1 year ago

[ ] future dates are correct, this is because of prolonged transitionary measures foreseen in the Regulation. Still, I would already list those species as Member States are already working on them.
[ ] Link to the consolidated list in the README is fine
[ ] Common names document: the IAS webpage of IUCN was refurbished recently (and the resources page for the EU Reg you find here) and doesn't seem to have a link to the file anymore. I filed a request with IUCN colleagues.
[ ] I have mentioned EASIN in the additional information sentence. We will communicate with them after we published the checklist to see if we can indeed in the future harvest it from their api instead (but for now I would refrain from mentioning any data gaps there).

timadriaens commented 1 year ago

I had answer for IUCN, here are the files with common names:

https://circabc.europa.eu/ui/group/4cd6cb36-b0f1-4db4-915e-65cd29067f49/library/2ed2ee2a-730f-4583-a3ac-bb2a1815ad6a/details

https://circabc.europa.eu/ui/group/4cd6cb36-b0f1-4db4-915e-65cd29067f49/library/1ac00d12-613b-447c-ab91-3016af071bcf/details

https://circabc.europa.eu/ui/group/4cd6cb36-b0f1-4db4-915e-65cd29067f49/library/fad036d3-e2df-4adb-9c7a-7b9593a4c2f8/details

IUCN have not yet merged those files...

damianooldoni commented 1 year ago

@timadriaens: I will add the link to those three files in README. Could you please check that these names are the same as the ones in our tsv? Or did you already done it? Thanks.

timadriaens commented 1 year ago

should we not include the common names in other languages? If you want I can do that.

damianooldoni commented 1 year ago

yes, we can. If you do, I am happy to check and map it further to DwC 👍 I also noticed that the names in the spreadsheets are not always correct as we think they should be, e.g. capital letters in French and English common names should be removed unless referring to a country, sin't? I also see that we are not always applying this rule: see e.g. "Pumpkinseed" which probably shoul be "pumpkinseed"? I let this issue to you as it is not my domain of expertise 😄

damianooldoni commented 1 year ago

We can discuss this further if you need in #14. We leave this issue for final review.

damianooldoni commented 1 year ago

Data and metadata have been reviewed.