#288 button-color loading improvements

ripe-tech / ripe-components-vue

Library of shared components to be re-used in Vue.js

http://ripe-components-vue.platforme.com

Apache License 2.0

7 stars 1 forks source link

Closed joaofsl closed 2 years ago

joaofsl commented 2 years ago

-	-
Issue	https://github.com/ripe-tech/ripe-util-vue/issues/288
Decisions	Add better loading style for other colors Remove hover and interaction while loading
Animated GIF

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you @joaofsl for submitting the "#302 button-color loading improvements" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ripe-components-vue	✅ Ready (Inspect)	Visit Preview	Sep 12, 2022 at 3:08PM (UTC)

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @joaofsl you may have to fix some errors:

Please specify a link to the issue or rationale in the description of the PR ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @joaofsl it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)