fix: `noFileSelected()` computed property to handle `null` values and consequently adapt `emptySlots()` computed property

ripe-tech / ripe-components-vue

Library of shared components to be re-used in Vue.js

http://ripe-components-vue.platforme.com

Apache License 2.0

7 stars 1 forks source link

fix: `noFileSelected()` computed property to handle `null` values and consequently adapt `emptySlots()` computed property #618

Closed beneditomauro closed 1 year ago

beneditomauro commented 2 years ago

-	-
Issue	https://github.com/ripe-tech/ripe-util-vue/issues/332
Dependencies	-
Decisions	-
Animated GIF

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ripe-components-vue	✅ Ready (Inspect)	Visit Preview	Nov 21, 2022 at 11:11AM (UTC)

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you @beneditomauro for submitting the "fix:noFileSelected() computed property to handle null values and consequently adapt emptySlots() computed property" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @beneditomauro it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @beneditomauro it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

3rdvision commented 2 years ago

Build is failing. I believe you need to port the following fixes: 1- https://github.com/ripe-tech/peri-templating/pull/55/commits/f7343478e1c2437429df6298ba8c32398bb200c4 2- https://github.com/ripe-tech/peri-templating/pull/55/commits/a281af2f896f2ea0e7fcce0b1cb089d92026c0df

@beneditomauro please check one by one as it might only need the first fix but not the second

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @beneditomauro it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

beneditomauro commented 1 year ago

Build is failing. I believe you need to port the following fixes: 1- ripe-tech/peri-templating@f734347 2- ripe-tech/peri-templating@a281af2

@beneditomauro please check one by one as it might only need the first fix but not the second

Neither worked, used this one: https://github.com/ripe-tech/peri-templating/pull/56/files, but not approved yet

3rdvision commented 1 year ago

Build is failing. I believe you need to port the following fixes: 1- ripe-tech/peri-templating@f734347 2- ripe-tech/peri-templating@a281af2 @beneditomauro please check one by one as it might only need the first fix but not the second

Neither worked, used this one: https://github.com/ripe-tech/peri-templating/pull/56/files, but not approved yet

@beneditomauro This is not the proper fix. You should have used both 1 and 2. Fixing the version of stylelint-config-hive is just mitigating the wrong versions.

3rdvision commented 1 year ago

@beneditomauro Since this was already merged I opened a PR on top of master with that change. Looks like after bumping stylelint versions, it got more advanced for some CSS selectors and simplified some cases :smile: