ripe-tech / ripe-components-vue

Library of shared components to be re-used in Vue.js
http://ripe-components-vue.platforme.com
Apache License 2.0
7 stars 1 forks source link

refactor: cleanup dead code var in slot #627

Closed 3rdvision closed 1 year ago

3rdvision commented 1 year ago
- -
Issue Cleanup dead code variable item in slot that generates vue warns (only visible after linking ripe-pulse and ripe-components-vue for instance). Note that: in order to make a v-bind:var="var" inside a slot, this slot needs to be inside a template that receives this item. This was probably done by mistake from copy/paste of previous examples.image
Decisions - Cleanup dead code var that generates a spam of warnings
ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Thank you @3rdvision for submitting the "refactor: cleanup dead code var in slot" pull request 😎.

Please do not forget to review our internal guidelines:

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ripe-components-vue ✅ Ready (Inspect) Visit Preview Jan 26, 2023 at 3:11PM (UTC)
ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @3rdvision you may have to fix some errors:

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
3rdvision commented 1 year ago

No changelog because it makes no sense to mention this kind of change.