search

ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

#768 Add size to setOptions #248

Closed 3rdvision closed 3 years ago

3rdvision commented 3 years ago
- -
Issue https://github.com/ripe-tech/ripe-white/issues/768
Decisions Add size to setOptions as suggested in https://github.com/ripe-tech/ripe-commons-pluginus/pull/222#issuecomment-780702882
joamag commented 3 years ago

This should be part of the configurator options and not the ripe instance... also we already have resolution change support in ripe white

image

gcandal commented 3 years ago

@joamag:

image

image

Even though it's under Configurator on ripe-white, it's actually calling the RIPE instance method: this.$bus.bind("size_change", size => self.ripe.setSize(size));

Why shouldn't this be part of setOptions if size is an option?

joamag commented 3 years ago

@joamag:

image

image

Even though it's under Configurator on ripe-white, it's actually calling the RIPE instance method: this.$bus.bind("size_change", size => self.ripe.setSize(size));

Why shouldn't this be part of setOptions if size is an option?

Seems to be a bad decision of the past, let's leave things as is and not extend the bad decision of the past.