createAttachmentOrder with meta

gcandal commented 3 years ago

Rationale

The creation of order attachments expects a file and a meta dictionary (see https://github.com/ripe-tech/ripe-core/blob/ba23882efa65acb165e924c6f836c6933646604f/src/ripe_core/controllers/api/order.py#L97).

However, the current SDK implementation of the endpoint doesn't support meta (see https://github.com/ripe-tech/ripe-sdk/blob/c9e7b8ab715d4339ccaac26fbff734df6718a316/src/js/api/order.js#L201).

Description

The implementation of the rationale above could probably be similar to:

    options = Object.assign(options, {
        url: url,
        method: "POST",
        dataM: {
            file: file,
            meta: JSON.stringify(meta)
        },
        auth: true
    });

But unless I'm missing something obvious, ripe-sdk doesn't support strings as values when using a multipart payload dataM (see https://github.com/ripe-tech/ripe-sdk/blob/c9e7b8ab715d4339ccaac26fbff734df6718a316/src/js/base/api.js#L1238).

Trying to use them results in RangeError: offset is out of bounds because the string is not being encoded, resulting in this:

ripe-tobias-bot[bot] commented 3 years ago

Woof, Woof!

Thank you for submitting the "createAttachmentOrder with meta" issue 😎.

Please do not forget to review our internal guidelines:

Describe the problem in the best possible way
Include at least the Description section, but considered adding other sections
Avoid suggesting immediate solutions, think deeply about the problem
Engage in the Triage process being as responsive as possible
Understand and accept the possibly large amount of execution time
Avoid immediate reallocation of the issue, let triage do their job

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)