ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

Fix: Override tracking info and keep other params #285

Closed joao-conde closed 3 years ago

joao-conde commented 3 years ago
- -
Issue --
Dependencies --
Decisions Other option values passed (for example justification) were not being propagated as expected to setOrderStatus.
ripe-tobias-bot[bot] commented 3 years ago

Woof, Woof!

Thank you for submitting the "Fix: Override tracking info and keep other params " pull request 😎.

Please do not forget to review our internal guidelines:

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
joamag commented 3 years ago

@gcandal @joao-conde let's add the required method params explicitly

gcandal commented 3 years ago

@gcandal @joao-conde let's add the required method params explicitly

@joamag wont' that be a breaking change? Also, it makes it incoherent with cancelOrder (e.g. https://github.com/ripe-tech/ripe-pulse/blob/fd0c1237dbb70e7356680ecd4d8acf607e9589fb/vue/components/pages/order/order-show/order-show.vue#L891)

joao-conde commented 3 years ago

Discussed personally: