ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

#650: Change to preferred frame after loading customization fix #286

Closed BeeMargarida closed 3 years ago

BeeMargarida commented 3 years ago
- -
Issue https://github.com/ripe-tech/ripe-white/issues/650
Dependencies --
Decisions • Configurator updates itself by redirecting its update call through its parent (Ripe instance). This allows access control and prevents 2 updates happening in the configurator at the same time, since the configurator does not have checks to prevent this.
• By redirecting the update to the parent, it becomes problematic when there are 2 or more configurators listening to the change frame request (e.g. ripe-white). This is because the update method uses the updateCounter and discards the previous update request if one more recent was made. To fix this, the update requests of the configurators are batched together in queryUpdate and only one update request is made with the configurators as the children array. This is the simplest way I could find, since the configurators have no information about each other and only ripe can make this logic.
Animated GIF preferred_frame_parent_update
ripe-tobias-bot[bot] commented 3 years ago

Woof, Woof!

Thank you for submitting the "#650: Change to preferred frame after loading customization fix" pull request 😎.

Please do not forget to review our internal guidelines:

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
joamag commented 3 years ago

@gcandal @BeeMargarida let's schedule a 30 min call to address this issue

BeeMargarida commented 3 years ago

Closing since a better approach was found