fix: sets default values for initials and engraving on image update

ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core

Apache License 2.0

8 stars 4 forks source link

-	-
Issue	--
Dependencies	--
Decisions	What is happening? In the specific case of the test, without setting the default values, there are two different requests: the first has the URL without initials and sets the `_loadedCallback` to its callback when it loads. However, when the second requests comes, it has a different URL and overrides the loadedCallback, never allowing the first request to finish. It's necessary to cancel the previous request before making a new one.
Animated GIF	Before: Now:

Issue

Dependencies

Decisions

What is happening?
In the specific case of the test, without setting the default values, there are two different requests: the first has the URL without initials and sets the _loadedCallback to its callback when it loads. However, when the second requests comes, it has a different URL and overrides the loadedCallback, never allowing the first request to finish.
It's necessary to cancel the previous request before making a new one.

Animated GIF

Before:

Now:

Woof, Woof!

Thank you for submitting the "fix: sets default values for initials and engraving on image update" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

ripe-tech / ripe-sdk

fix: sets default values for initials and engraving on image update #302