fix: support combinations for initials builder of only 1 profile

BeeMargarida commented 3 years ago

-	-
Issue	Found when implementing initials in ripe-green.
Dependencies	--
Decisions	When only when profile was given (which is rarely), the itertools combination would not work, so a check was added, since all combinations of only one element is the element itself.
Animated GIF	--

ripe-tobias-bot[bot] commented 3 years ago

Woof, Woof!

Thank you for submitting the "fix: support combinations for initials builder of only 1 profile" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

gcandal commented 3 years ago

Does ripe.combinations map 1-1 to some itertools method? If it does, is it behaving the same way?

BeeMargarida commented 3 years ago

I verified, the result is the same. I don't know what happened, but I can't replicate the problem I found when I created this PR. I'll close it

ripe-tech / ripe-sdk