#307: Disable masks if build contains "no_masks" tag

BeeMargarida commented 3 years ago

-	-
Issue	https://github.com/ripe-tech/ripe-sdk/issues/307
Dependencies	--
Decisions	Checks if build contains `no_masks` tag and disables the masks in the configurator. It takes precendence over the options passed to the configurator.
Animated GIF	--

ripe-tobias-bot[bot] commented 3 years ago

Woof, Woof!

Thank you for submitting the "#307: Disable masks if build contains "no_masks" tag" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

BeeMargarida commented 3 years ago

Tests failing due to something unrelated to this PR, investigating

ripe-tech / ripe-sdk