#240 Order States - Githubissues

3rdvision commented 3 years ago

-	-
---	---
Issue	https://github.com/ripe-tech/ripe-pulse/issues/240
Dependencies	https://github.com/ripe-tech/ripe-core/pull/4610
Decisions	- Add order state API methods to allow for order past state filtering

ripe-tobias-bot[bot] commented 3 years ago

Woof, Woof!

Thank you for submitting the "#240 Order States" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

gcandal commented 3 years ago

Waiting on https://github.com/ripe-tech/ripe-core/pull/4610 since design changes might impact this one.

gcandal commented 3 years ago

Closing as not relevant since the core commit ended up being reverted due to security reasons (https://github.com/ripe-tech/ripe-core/commit/82a0dc2ee1c17c9b72a5af50a2ff314ec71443ba)

ripe-tech / ripe-sdk