Closed veryprofessionaldodo closed 2 years ago
Woof, Woof!
Thank you for submitting the "Added generic bind configurator for PRC and CSR" pull request 😎.
Please do not forget to review our internal guidelines:
Engaging in the development process in the best possible way helps it being efficient and fast.
Your friend, Tobias (Platforme's mascot)
@veryprofessionaldodo Is this dead? There is no one assigned
@NFSS10 Nice catch, I had forgotten about this to be honest. It was something I did when trying CSR inside RIPE White, and it's still valid. I'll assign it to you, it's quite straightforward and entirely backwards-compatible. The default behaviour is the same as the current one.
@veryprofessionaldodo Also, don't forget to add the labels and link the issue (if possible) both in the title and in the PR description
@NFSS10 , weirdly, the only linting suggestions were in the other file. Still, it failed in one of the tests. I'll revert it to it's previous state.
@NFSS10 , weirdly, the only linting suggestions were in the other file. Still, it failed in one of the tests. I'll revert it to it's previous state.
Could just be a different problem 🤷♂️ Either way the ideia is to keep the problems seperated. If the fails are checking before of the changes we made we should fix them, if the checks are failling but it isn't our code, no problem we should investigate why and open a fix in another PR.
Also don't forget to click that review request button so I know you want me to check the PR again.
@NFSS10 will do, thanks!
@hugo-gomes Could this be picked up? It's something that's critical for CSR, and it would be a step forward for that to be production-ready.
bindConfigurator
method in the SDK equates to generating a PRC configurator. This change allows the configurator to be initialized to be a CSR configurator, while still defaulting to PRC. In the end, no change in behaviour will occur unless it is explicitly stated to initialize a CSR configurator.