feat: use config animate if update is made after config

BeeMargarida commented 3 years ago

-	-
Issue	ConfigAnimate was not being used anywhere, making it impossible to disable the animation when first starting the configurator. (The last usage of configAnimate: https://github.com/ripe-tech/ripe-sdk/commit/eae86f176455956d5001d38747c2e579145b52d8#diff-44149027047186f90ca764a3b50eacce3ee815a9f66e73889332689a453b85bd)
Dependencies	--
Decisions	- In the configurator `update` method, checks if no signature exists before (meaning that it's a new config), if that is the case, it uses the configAnimate to set the animation (if defined).
Animated GIF	Before: Now:

ripe-tobias-bot[bot] commented 3 years ago

Woof, Woof!

Thank you for submitting the "feat: use config animate if update is made after config" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

BeeMargarida commented 3 years ago

CI failing due to dependency problem, not related to the changes made in this PR. Investigating the problem

ripe-tech / ripe-sdk