fix: explicitly add eslint-plugin-mocha dependency

[BeeMargarida]

-	-
Issue	CI is failing (https://github.com/ripe-tech/ripe-sdk/runs/3937347918) due to a npm@^8 bug (https://github.com/npm/cli/issues/3881), where there is inconsistencies in the install behaviour. This does not happen in previous versions and can be replicated locally only with npm@^8 installed.
Dependencies	--
Decisions	- Explicitly add eslint-plugin-mocha dependency.
Animated GIF	--

[ripe-tobias-bot[bot]]

Woof, Woof!

Thank you for submitting the "fix: explicitly add eslint-plugin-mocha dependency" pull request 😎.

Please do not forget to review our internal guidelines:

• Review the code in the PR using a peer 🧑‍🤝‍🧑
• Make sure all the linting process has been executed an passed 👌
• Make sure unit tests are passing ✅
• Ensure that proper code standards are met 📋
• Fill in the PR's summary (issue, dependencies, decisions and GIF)
• Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

[joamag]

@BeeMargarida this is weird can we talk a bit about this? Just to clarify the inconsistent behavior between npm>=8 and the other versions

[BeeMargarida]

@BeeMargarida this is weird can we talk a bit about this? Just to clarify the inconsistent behavior between npm>=8 and the other versions

There were some changes in the way npm now deals with the install process (not in version 8 but before in recent versions of npm7 - https://github.com/npm/cli/issues/2339, https://github.com/npm/cli/issues/2339#issuecomment-817013188) (still trying to pin-point what), but basically the problem is the node_modules result regarding dependencies of dependencies:

npm@7.7.6	npm@8.1.0

In the latest version, the eslint-plugin-mocha is inside the eslint-config-hive dependency and not accessible. One thing that could possible work is defined eslint-plugin-mocha and eslint-plugin-vue as peerDependencies of eslint-config-hive (not tested, just a possible fix). All the other dependencies of eslint-config-hive that are outside its node_modules are peerDependencies of other packages. Other possibility is running npm i --legacy-peer-deps.

[joamag]

One thing that could possible work is defined eslint-plugin-mocha and eslint-plugin-vue as peerDependencies of eslint-config-hive (not tested, just a possible fix). All the other dependencies of eslint-config-hive that are outside its node_modules are peerDependencies of other packages.

Yeah let's schedule 15 min to talk about this one.