#923 Add default locale bundle initialization

3rdvision commented 2 years ago

-	-
Issue	https://github.com/ripe-tech/ripe-white/issues/923
Decisions	- Initialize both the SDK locale bundle and the SDK default locale bundle so it's possible to fallback .
Animated GIF

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you for submitting the "#923 Add default locale bundle initialization" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

joamag commented 2 years ago

@3rdvision I'm not sure about the overall strategy. Why do we need the default (fallback) locale bundle to be loaded?

3rdvision commented 2 years ago

Why do we need the default (fallback) locale bundle to be loaded?

Because the default fallback locale is not loaded and the issue appears when we visit a ripe-white link with a locale that doesn't exist, it first loads the empty locale map for the nonexistent locale and then falls back to the default en_us locale which never loaded in the first place.

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

ripe-tech / ripe-sdk

#923 Add default locale bundle initialization #324