ripe-tobias-bot[bot]
commented
2 years ago Woof, Woof!
Thank you for submitting the "#276: shipment API" pull request 😎.
Please do not forget to review our internal guidelines:
- Review the code in the PR using a peer 🧑🤝🧑
- Make sure all the linting process has been executed an passed 👌
- Make sure unit tests are passing ✅
- Ensure that proper code standards are met 📋
- Fill in the PR's summary (issue, dependencies, decisions and GIF)
- Double-check the diff to make sure it's the absolute best solution you can come up with
Engaging in the development process in the best possible way helps it being efficient and fast.
Your friend, Tobias (Platforme's mascot)
joao-conde
getShipments/getShipmentsPandcreateShipment/createShipmentsP.The params are all documented. While extensive, I feel like external SDK users can have more autonomy this way. It also helps us internally, making teams more autonomous and non-reliant on a specific person's knowledge.