#281 Bulking support - Githubissues

joaofsl commented 2 years ago

-	-
Issue	https://github.com/ripe-tech/ripe-pulse/issues/281
Decisions	Add missing methods to create a bulk order.

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you for submitting the "#281 Bulking support" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @joaofsl you may have to fix some errors:

You either forgot to add the no-changelog label to this PR, or to log the changes in CHANGELOG.md file. Please try to fix this and then re-assign PR. ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

BeeMargarida commented 2 years ago

@joaofsl Missing changelog, also this needs to be ported to ripe-api in Python (all bulk order methods actually :disappointed:)

BeeMargarida commented 2 years ago

@joaofsl Please link the issue in the changelog entry

ripe-tech / ripe-sdk