ripe-tobias-bot[bot]
commented
2 years ago Woof, Woof!
Thank you for submitting the "feat: resolve invoice rule function" pull request 😎.
Please do not forget to review our internal guidelines:
- Review the code in the PR using a peer 🧑🤝🧑
- Make sure all the linting process has been executed an passed 👌
- Make sure unit tests are passing ✅
- Ensure that proper code standards are met 📋
- Fill in the PR's summary (issue, dependencies, decisions and GIF)
- Double-check the diff to make sure it's the absolute best solution you can come up with
Engaging in the development process in the best possible way helps it being efficient and fast.
Your friend, Tobias (Platforme's mascot)
In peri-invoicing it is necessary to get a invoice rule for a specific brand, model and country. The endpoint to list available from the SDK does not allow very complex queries, so the need for this new endpoint. Using list endpoint - https://ripe-core-sbx.platforme.com/api/invoice_rules?filter_operator=$or&filters=brand:eq:swear&filters=shoe:eq:regent&filters=country:eq:PT- the wanted rule would be the second one.