Closed BeeMargarida closed 2 years ago
Woof, Woof!
Thank you @BeeMargarida for submitting the "fix: use locked dimensions for configurator (the face default) and apply DPR" pull request 😎.
Please do not forget to review our internal guidelines:
Engaging in the development process in the best possible way helps it being efficient and fast.
Your friend, Tobias (Platforme's mascot)
Woof, Woof!
Oops! @BeeMargarida you may have to fix some errors:
Please address these issues to continue with the Pull Request merge process.
Your friend, Tobias (Platforme's mascot)
-
pixelRatio
was not being applied- Was using the container size for the image instead of a locked one, which resulted in pixelated images when switching from mobile to desktop
this.owner.getSize("$base", <current face>)
. This can be changed by setting the configurator variableuseDefaultSize
tofalse
.- Applies
pixelRatio
to the images downloaded for the configurator and does not allow its size to exceed the maximum for that face - with the behaviour by default this is now not "useful", but it is ifuseDefaultSize
is false.