style: pretty - Githubissues

ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core

https://www.platforme.com

Apache License 2.0

8 stars 4 forks source link

style: pretty #360

Closed joao-conde closed 2 years ago

joao-conde commented 2 years ago

-	-
Issue	--
Dependencies	--
Decisions	I do not see a reason not to do this albeit there might be one. It is annoying that some files were not linted/prettified. Not only should they be, but we have a huger local git diff unnecessarily after running pretty. No one wants to commit these changes in non-related PRs, so I am opening this one.

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you @joao-conde for submitting the "style: pretty" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @joao-conde you may have to fix some errors:

Please specify a link to the issue or rationale in the description of the PR ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

BeeMargarida commented 2 years ago

@joao-conde Relative to the javascript file inside src/python, I don't think that is the solution, I think it is related to the differences in setup between prettier and lint. (lint only targets src/js and prettier targets all src). The linting changes made to that file to not match the standards we use. I think I can fix this setup problem, let me try