ripe-tobias-bot[bot]
commented
2 years ago Woof, Woof!
Thank you @BeeMargarida for submitting the "fix: use same linting directories for prettier" pull request 😎.
Please do not forget to review our internal guidelines:
- Review the code in the PR using a peer 🧑🤝🧑
- Make sure all the linting process has been executed an passed 👌
- Make sure unit tests are passing ✅
- Ensure that proper code standards are met 📋
- Fill in the PR's summary (issue, dependencies, decisions and GIF)
- Double-check the diff to make sure it's the absolute best solution you can come up with
Engaging in the development process in the best possible way helps it being efficient and fast.
Your friend, Tobias (Platforme's mascot)
gulpfile, only thesrc/jsfiles are being analyzed. In prettier thejsfiles insidesrc/pythonwere also being analyzed, which caused changes that do not reflect our linting standards to be made each time we ranyarn pretty. -> The same logic present ingulpfilewas applied to prettier. If we made the contrary, several changes would need to be made to makesrc/python/ripe_demo/static/js/main.jscompliant to our linting standards.