ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

#363 YSL: Improve update cancellation strategy #366

Closed 3rdvision closed 2 years ago

3rdvision commented 2 years ago
- -
Issue https://github.com/ripe-tech/ripe-sdk/issues/357
Decisions - Improve update cancellation strategy by adding a cancel event to cancel ongoing update promises

Note: Although a debouncer solution could still be implemented, this change is enough to solve the identified performance issue.

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you @3rdvision for submitting the "#363 YSL: Improve update cancellation strategy" pull request 😎.

Please do not forget to review our internal guidelines:

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @3rdvision you may have to fix some errors:

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
3rdvision commented 2 years ago

Just as a curiosity, is the performance similar to the debouncer solution?

The performance is better because we no longer have to always wait for the debouncer's default 275ms timeout 😄

3rdvision commented 2 years ago

Going to refactor to cancel the await this.initialsBuilder instead

joamag commented 2 years ago

@3rdvision Adding fast-track to this one as YSL needs this one

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
joamag commented 2 years ago

@3rdvision We need to double-check that everything works. But I believe this solution is regenerator-runtime proof