Closed 3rdvision closed 2 years ago
Woof, Woof!
Thank you @3rdvision for submitting the "#363 YSL: Improve update cancellation strategy" pull request 😎.
Please do not forget to review our internal guidelines:
Engaging in the development process in the best possible way helps it being efficient and fast.
Your friend, Tobias (Platforme's mascot)
Woof, Woof!
Oops! @3rdvision you may have to fix some errors:
Please address these issues to continue with the Pull Request merge process.
Your friend, Tobias (Platforme's mascot)
Just as a curiosity, is the performance similar to the debouncer solution?
The performance is better because we no longer have to always wait for the debouncer's default 275ms timeout 😄
Going to refactor to cancel the await this.initialsBuilder
instead
@3rdvision Adding fast-track to this one as YSL needs this one
Woof, Woof!
Oops! @3rdvision it looks like the PR check have just failed.
Please try to fix them as soon as possible.
Your friend, Tobias (Platforme's mascot)
Woof, Woof!
Oops! @3rdvision it looks like the PR check have just failed.
Please try to fix them as soon as possible.
Your friend, Tobias (Platforme's mascot)
Woof, Woof!
Oops! @3rdvision it looks like the PR check have just failed.
Please try to fix them as soon as possible.
Your friend, Tobias (Platforme's mascot)
Woof, Woof!
Oops! @3rdvision it looks like the PR check have just failed.
Please try to fix them as soon as possible.
Your friend, Tobias (Platforme's mascot)
@3rdvision We need to double-check that everything works. But I believe this solution is regenerator-runtime proof
cancel
event to cancel ongoing update promisesNote: Although a debouncer solution could still be implemented, this change is enough to solve the identified performance issue.