#4703 Add size to rules

[3rdvision]

-	-
Issue	https://github.com/ripe-tech/ripe-core/issues/4703
Dependencies	https://github.com/ripe-tech/ripe-core/pull/4707
Decisions	- Adapt ripe-sdk methods to new size dimensions in rules. - Add missing resolveTransportRule and resolveTransportRuleP methods.

[ripe-tobias-bot[bot]]

Woof, Woof!

Thank you @3rdvision for submitting the "#4703 Add size to rules" pull request 😎.

Please do not forget to review our internal guidelines:

• Review the code in the PR using a peer 🧑‍🤝‍🧑
• Make sure all the linting process has been executed an passed 👌
• Make sure unit tests are passing ✅
• Ensure that proper code standards are met 📋
• Fill in the PR's summary (issue, dependencies, decisions and GIF)
• Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

[3rdvision]

Shouldn't this be done for transport-rule, availability-rule and price-rule as well?

for which methods? Everything is passed through options and as for the resolve method, there's only resolveInvoiceRule

[BeeMargarida]

Shouldn't this be done for transport-rule, availability-rule and price-rule as well?

for which methods? Everything is passed through options and as for the resolve method, there's only resolveInvoiceRule

Nvm, i did not notice those don't have resolve methods. However, transport-rule should have (I guess it wasn't ported at the time) because there is an endpoint for it - https://github.com/ripe-tech/ripe-core/blob/7a0a2eed80467916980ecd02f487d307ca5cfa60/src/ripe_core/controllers/api/rules/transport_rule.py#L49 Perhaps this PR should add it, since it is basically the same as the one for invoice rule

[ripe-tobias-bot[bot]]

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

[3rdvision]

blocked until https://github.com/ripe-tech/ripe-core/pull/4707 is merged