#317: filter and fetch justifications by code

ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core

https://www.platforme.com

Apache License 2.0

8 stars 4 forks source link

#317: filter and fetch justifications by code #374

Closed joao-conde closed 2 years ago

joao-conde commented 2 years ago

-	-
Issue	https://github.com/ripe-tech/ripe-pulse/issues/317
Dependencies	--
Decisions	Moving the default logic (of resolving `context:code` or just `code_full`) to the SDK. Also hides away the logic of the `other;` "escape hatch". This logic would have to be repeated in clients like RIPE Robin or RIPE Pulse (and future ones). Alternative to this

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you @joao-conde for submitting the "#317: filter and fetch justifications by code" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

joao-conde commented 2 years ago

@joamag just an idea but maybe this could be moved to an endpoint on the RIPE Core justifications API? Because otherwise all this logic will be repeated across API clients (JS, python, android and iOS SDKs)

joamag commented 2 years ago

@joamag just an idea but maybe this could be moved to an endpoint on the RIPE Core justifications API? Because otherwise all this logic will be repeated across API clients (JS, python, android and iOS SDKs)

Agree let's move this to the server-side

joao-conde commented 2 years ago

Closing due to favor of https://github.com/ripe-tech/ripe-core/pull/4721