#966: Image support for external image providers/frame validators

BeeMargarida commented 2 years ago

-	-
Issue	https://github.com/ripe-tech/ripe-white/issues/996
Dependencies	https://github.com/ripe-tech/ripe-core/pull/4710
Decisions	- Added support in `image.js` for external image URL providers and frame validators. With this, the thumbnail component just needs to make `bindImage´ with the correct provider and SDK deals with the rest (update parts, change frame, etc)
Animated GIF	Below

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you @BeeMargarida for submitting the "#966: Image support for external image providers/frame validators" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

joamag commented 2 years ago

@BeeMargarida lets add the bindVideoThumbnail method that uses bindImage to simplify the API ;)

joamag commented 2 years ago

👏

ripe-tech / ripe-sdk