Closed NFSS10 closed 2 years ago
As there isn't a method in ripe-sdk to get the order image URL so currenlty we manually build the order image URL. Examples: ripe-pulse, ripe-robin-revamp, ripe-util-vue, ripe-copper, etc
Having a method to handle this will make the situation less error prone and ensure that compatiblity is maintained everywhere.
Add a method in ripe-sdk to build and return an order image URL.
Add a method called _getOrderImageURL here. The approach would be similar to, for example, _getOrderReportPNGURL
_getOrderImageURL
https://github.com/ripe-tech/products/issues/38 was created because inconsistencies were found between order image URL for build and buildless types.
Test OK :+1:
dsafonso
commented
2 years ago dsafonso
commented
2 years ago
Rationale
As there isn't a method in ripe-sdk to get the order image URL so currenlty we manually build the order image URL. Examples: ripe-pulse, ripe-robin-revamp, ripe-util-vue, ripe-copper, etc
Having a method to handle this will make the situation less error prone and ensure that compatiblity is maintained everywhere.
Description
Add a method in ripe-sdk to build and return an order image URL.
Implementation
Add a method called
_getOrderImageURLhere. The approach would be similar to, for example, _getOrderReportPNGURLReference
https://github.com/ripe-tech/products/issues/38 was created because inconsistencies were found between order image URL for build and buildless types.
Estimation