Closed NFSS10 closed 2 years ago
The methods _getOrderReportURL, _getOrderReportPDFURL and _getOrderReportPNGURL aren't correctly handling params as they are being ignored and not properly added to the URL. The methods sould be fixed and the tests updated to catch those cases.
_getOrderReportURL
_getOrderReportPDFURL
_getOrderReportPNGURL
params
_getOrderReportPNGURL(1234, "secret-key", { params: { size: 100 } });
orders/1234/report.png?key=secret-key&size=100
orders/1234/report.png?key=secret-key
options
Test OK :+1:
Description
The methods
_getOrderReportURL
,_getOrderReportPDFURL
and_getOrderReportPNGURL
aren't correctly handlingparams
as they are being ignored and not properly added to the URL. The methods sould be fixed and the tests updated to catch those cases.Expected vs. Observed
_getOrderReportPNGURL(1234, "secret-key", { params: { size: 100 } });
should returnorders/1234/report.png?key=secret-key&size=100
_getOrderReportPNGURL(1234, "secret-key", { params: { size: 100 } });
returnsorders/1234/report.png?key=secret-key
Repro Steps
params
passed tooptions
params
are ignoredEnvironment