search

ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

#135 Add `fromArrayBuffer` and `fromBlob` to `FileTuple` #393

Closed NFSS10 closed 2 years ago

NFSS10 commented 2 years ago
- -
Issue Port from https://github.com/hivesolutions/yonius/pull/39 (related to https://github.com/ripe-tech/hermes-proxy/issues/135)
Dependencies --
Decisions • Add fromArrayBuffer and fromBlob to FileTuple
• Add tests: #fromString(), #fromArrayBuffer() and #fromBlob()

imagem

imagem

NFSS10 commented 2 years ago

Looks good for the most part, I would also order the fromX methods by alphabetical order (and corresponding test suites)

As to the order, it takes into the account the methods declaration and dependence, as is more important to follow than logic thread than the alphabetical order (makes the code easier to read)

fromData -> independent fromString -> dependent on fromData fromArrayBuffer -> dependent on fromData fromBlob -> dependent on fromArrayBuffer