fix: initialsSpec profile spread fallback value in image

BeeMargarida commented 2 years ago

-	-
Issue	https://github.com/ripe-tech/ripe-white/issues/1014#issuecomment-1147233417
Dependencies	--
Decisions	- Fix initialsSpec profile spread fallback value in image
Animated GIF	--

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you @BeeMargarida for submitting the "fix: initialsSpec profile spread fallback value in image" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @BeeMargarida you may have to fix some errors:

Please specify a link to the issue or rationale in the description of the PR ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

BeeMargarida commented 2 years ago

@joamag The change to default to [] actually changes the requests sent to the compose, which breaks our existing tests. Is this something we really want? Before it was possibly to send a request with no profiles

joamag commented 2 years ago

you're right

ripe-tech / ripe-sdk

fix: initialsSpec profile spread fallback value in image #399