ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

fix: import order DKU #402

Closed joao-conde closed 2 years ago

joao-conde commented 2 years ago
- -
Issue --
Dependencies --
Decisions Contents filled only if there are values. If there are none, dont send an object with null values. Pass DKU if it exists. Add a size to import order.
Passing no size, previously, we had a contents like { size: null } and this does not fail when importing. Meaning there is some bug in Core, to be fixed in another PR.
Animated GIF --
ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Thank you @joao-conde for submitting the "fix: import order DKU" pull request 😎.

Please do not forget to review our internal guidelines:

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @joao-conde you may have to fix some errors:

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
joao-conde commented 2 years ago

CI failing due to SBX probably an example of flaky tests, this passes local tests and the order can be imported correctly even against SBX

ripe-tobias-bot[bot] commented 2 years ago

Woof, Woof!

Oops! @joao-conde it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot