fix: no mask buffers if useMasks false

ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core

https://www.platforme.com

Apache License 2.0

8 stars 4 forks source link

Closed joao-conde closed 1 year ago

joao-conde commented 1 year ago

-	-
Issue	https://github.com/ripe-tech/ripe-sdk/issues/446
Dependencies	--
Decisions	If masks are turned off, we cant create the mask buffers (image elements) because they will load the masks anyways even if disabled.
Animated GIF	--

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Thank you @joao-conde for submitting the "fix: no mask buffers if useMasks false" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @joao-conde you may have to fix some errors:

You either forgot to add the no-changelog label to this PR, or to log the changes in CHANGELOG.md file. Please try to fix this and then re-assign PR. ❗️
Please specify a link to the issue or rationale in the description of the PR ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @joao-conde it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

joao-conde commented 1 year ago

Closing this as the solution is not ideal