ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

No masks options disable highlighting but masks are still loaded #446

Closed joao-conde closed 1 year ago

joao-conde commented 1 year ago

Description

Through the use of noMasks or useMasks one can control whether the masks are used. However, even when not using them, the SDK still loads them and these represent a significant amount of network requests. We should not load masks if they are not going to be used.

Expected vs. Observed

- -
Expected The masks are show and not loaded i.e. no network requests for masks are made.
Observed The masks are not shown but are loaded and you can see it in the network requests.

Repro Steps

  1. Initialize our RIPE in this repo
  2. Set useMasks: false or noMasks: true in the bindConfigurator method
  3. Build the SDK, launch the demo, go to localhost:8080/simple network tab

Screens

image

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Thank you @joao-conde for submitting the "No masks options disable highlighting but masks are still loaded" issue 😎.

Please do not forget to review our internal guidelines:

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
msp-platforme commented 1 year ago

:+1: When masks are on (parameter use_masks=1) we see a lot of network requests and we can also hover the model and see the masks. image

When masks are off (parameter use_masks=0) we don't see network requests related to maks and we if we hover the model it does not have masks. image