ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

fix: load mask only if using masks #447

Closed joao-conde closed 1 year ago

joao-conde commented 1 year ago
- -
Issue https://github.com/ripe-tech/ripe-sdk/issues/446
Dependencies --
Decisions If masks are not to be used, just avoid loading them but create the buffers anyways.
Animated GIF Before
image After
image

For example, using the following test script:

configuratorPrc = ripe.bindConfigurator(element, {
    duration: 250,
    useMasks: true,
    view: bestFace(result)
});
configuratorPrc.isFirst = true;

setTimeout(() => {
    configuratorPrc.updateOptions({ useMasks: false });
}, 6000);

I was able to start out with masks and 6 seconds later have them disappear and requests stopped being made:

disablemasks

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Thank you @joao-conde for submitting the "fix: load mask only if using masks" pull request 😎.

Please do not forget to review our internal guidelines:

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @joao-conde it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot