ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

#271 Add quantity param to import order #448

Closed 3rdvision closed 1 year ago

3rdvision commented 1 year ago
- -
Issue https://github.com/ripe-tech/ripe-pulse/issues/271
Decisions - Add quantity param to _importOrder method
ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Thank you @3rdvision for submitting the "#271 Add quantity param to import order" pull request 😎.

Please do not forget to review our internal guidelines:

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
3rdvision commented 1 year ago

I was able to run these tests against ripe-core master running locally and I believe we should ignore it failing for now.

The tests are not passing for 2 reasons:

1- RIPE Core SANDBOX downtime is bad which makes it hard to run tests as the probability that the server is down because it's installing some build is high.

2- I'm not sure if config.TEST_URL=https://ripe-core-sbx.platforme.com/api/ or if it's another environment (I don't have access) and that ripe-core might not be the latest version - it might be without this patch https://github.com/ripe-tech/ripe-core/pull/4766

joao-conde commented 1 year ago

@3rdvision I think for tests the default is being used, which is sandbox.

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot
ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @3rdvision it looks like the PR check have just failed.

Please try to fix them as soon as possible.

Your friend, Tobias (Platforme's mascot)

Tobias Bot