Closed 3rdvision closed 1 year ago
Woof, Woof!
Thank you @3rdvision for submitting the "Tests are consistently failing and deployment is failing" issue 😎.
Please do not forget to review our internal guidelines:
Description
section, but considered adding other sectionsEngaging in the development process in the best possible way helps it being efficient and fast.
Your friend, Tobias (Platforme's mascot)
Closing this as this specific error is no longer occurring.
Description
The
npm run test
step of the deployment is consistently failing in the same step and is not related to the deployment.The error log is the following:
After an in-depth inspection the error is caused because of the race condition to delete the SKU at https://github.com/ripe-tech/ripe-sdk/blob/master/test/js/api/config.js#L199
This implementation of Promise will run after the test block is complete and call
done
a little bit after the previous requests are also complete which means done() will be called 2 times and thus the error "done() called multiple times".This is not reproducible locally which means that is impacted by the network and processing speed - because the workflows are run on a low tier container it always reproduces.
Expected vs. Observed
Repro Steps
yarn && yarn build && yarn test