#416 Auth callback - Githubissues

3rdvision commented 1 year ago

-	-
Issue	https://github.com/ripe-tech/ripe-robin-revamp/issues/416
Decisions	- Add `authCallback` to global options and improved overall behavior - returning the callback to allow one call authentication.

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Thank you @3rdvision for submitting the "#416 Auth callback" pull request 😎.

Please do not forget to review our internal guidelines:

Review the code in the PR using a peer 🧑‍🤝‍🧑
Make sure all the linting process has been executed an passed 👌
Make sure unit tests are passing ✅
Ensure that proper code standards are met 📋
Fill in the PR's summary (issue, dependencies, decisions and GIF)
Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend, Tobias (Platforme's mascot)

ripe-tobias-bot[bot] commented 1 year ago

Woof, Woof!

Oops! @3rdvision you may have to fix some errors:

You either forgot to add the no-changelog label to this PR, or to log the changes in CHANGELOG.md file. Please try to fix this and then re-assign PR. ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend, Tobias (Platforme's mascot)

hugo-gomes commented 1 year ago

3rdvision commented 1 year ago

@3rdvision https://calendly.com/d/x4q-nvs-cm8/416-auth-callback

Scheduled to 11:30 - 12:00, Wednesday, February 1, 2023.

ripe-tech / ripe-sdk