search

ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

#1098 Add params to `ready` event in configurator csr and prc #484

Closed 3rdvision closed 1 year ago

3rdvision commented 1 year ago
- -
Issue https://github.com/ripe-tech/ripe-white/issues/1098
Decisions - Add params to ready event in configurator csr and prc, allowing for any loaders to catch this event. This is because ready event is triggered in a lot of places and not specific enough to use as a loader bind.
NFSS10 commented 1 year ago

@3rdvision Also update PR info like title and stuff

3rdvision commented 1 year ago

@3rdvision Also update PR info like title and stuff

@NFSS10 done

NFSS10 commented 1 year ago

@3rdvision Just a thing that I noticed.

Isn't there a conflict on initializing the id with this? https://github.com/ripe-tech/ripe-sdk/blob/3bf809a5a6fee6d905fbfc007a53d81cd8f639cc/src/js/visual/visual.js#L50

3rdvision commented 1 year ago

@3rdvision Just a thing that I noticed.

Isn't there a conflict on initializing the id with this?

https://github.com/ripe-tech/ripe-sdk/blob/3bf809a5a6fee6d905fbfc007a53d81cd8f639cc/src/js/visual/visual.js#L50

Good call. I think they are different because this.id is the ripeInstance id and inside the configurator scope this.id is the configurator id.

I double checked and it's the case: image