search

ripe-tech / ripe-sdk

The public Javascript SDK for RIPE Core
https://www.platforme.com
Apache License 2.0
8 stars 4 forks source link

#132 Custom compose url #517

Closed 3rdvision closed 1 year ago

3rdvision commented 1 year ago

Issue

Dependencies

Decisions

Screenshots

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ripe-sdk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 5:15pm
3rdvision commented 1 year ago

@3rdvision add some unit tests

An effective way of testing this would be to initialize ripe-sdk with a custom composeUrl and checking if the returned URL from _getImageURL would have the expected base URL. Unfortunately, we don't do API testing in ripe-sdk so unless we change this high level decision, there's no space for a tests like these...

But this is indeed a risky change and it would be great if someone else could triple-check it.

I have tested it locally and it's working on my end. Going to request 3 peer reviews given the risk.

3rdvision commented 1 year ago

@hugo-gomes Sure, I enriched that set of tests with this new case

3rdvision commented 1 year ago

@hugo-gomes Can you please re-approve please? Fixed the changelog issue link.