riperiperi / FreeSO

Re-implementation of The Sims Online.
http://freeso.org
Mozilla Public License 2.0
817 stars 95 forks source link

Fix: People cannot call phone actions in Simitone. #135

Closed simptomo closed 4 years ago

simptomo commented 5 years ago

Thanks!

riperiperi commented 5 years ago

Hey,

Thanks for the PRs, If I knew someone was going to work on Simitone I would have committed my local changes to fix things up! I've done that now, but you might have to manually set FreeSO's submodule commit to the latest.

As for this change, you appear to have made every object in the game a GlobalSimObject. This will spawn every "normal" object in the game out of world whenever you load a property - that is very slow and could cause some very unexpected things to happen. I haven't encountered this issue with the latest changes I committed, so perhaps see if the issue persists on those?

I'll be working on FreeSO for a bit longer so these changes to simitone I committed will be the last for a while - meaning any fixes you want to work on will go unimpeded, but I recommend the following for future PRs:

riperiperi commented 4 years ago

Addressed by myself - There is one global object that is not normal type and should be included, and many of type 12 (gift tokens?) that shouldn't, so I made the check GlobalSimObject = obj.Global == 1 && obj.ObjectType != OBJDType.GiftToken