thertzelle
commented
5 years ago Updated this branch and PR with a new commit to fix the requested issues: https://github.com/riperiperi/FreeSO/pull/136/commits/6ccbc35371050f31283a3cae867c663846467714
- FSOFacade: Updating the location of the profile, allowed us to use the previous 'using FSO.Client.UI.Panels' declaration.
- UILotControl: Removed hack for grabbing MessageStringID 19. Updated jobcontroller.piff to set the type from message to FSOJOB.
- UIPersonPage: Updated the using directive location to be more appropriate.
- UIJobInfo: Updated the namespace of location of this class; Corrected spelling mistake of Destroy. Removed default color and shadow sets on yellow text fields; calling Dispose on bespoke texture for progress bar. Remove redeleration of 'ShowDialog' in favor of using the UIScreen.GloablShowDialog method.
- VMDialogPrivateStrings: Set this to 127 to prove that I knew what I was modifying, and just left it here. It IS set to 127 in the included piff change.
Here is the attached jobcontroller.piff file, minor change was to the 4096 - Get Current Job Info Tree, Used by all Phones for "Call Work". Dialog Type was changed to FSOJob / 127 from the VMDialogType enum.
jobcontroller.zip - File had to be zipped as github doesn't accept .piff files; If you would be more comfortable I can sent you the file in discord.
This PR adds a new UIJobInfo class that is able to take in variables from both the UIPersonPage and UILotControl (Job Grade [Level], Job Type, and Total Cumulative Experience Points), and display a nicer looking UI and provide some additional information that is helpful as you progress through your job. The two new bits of information is what you current job level is, and your performance, which is a progress bar, that gives you a % till promotion.
These changes have been extensively tested on all the current job career paths and tested on various roll overs from one grade to another.
This is my first UI element addition to FreeSO, so I did my best to make it look as nice as I could, and match the required look and feel of FreeSO / TSO. Please let me know here if you have any additional feedback or suggestions; or find me on Discord.
Here is how the current dialog looks when you retrieve it by phone call:
And here is the new version of the dialog (called with a different sim):
Currently for this update, if you are unemployed, you will still see the previous style dialog:
Here are a few more additional screenshots with different job grades and job types: