search

riperiperi / FreeSO

Re-implementation of The Sims Online.
http://freeso.org
Mozilla Public License 2.0
829 stars 96 forks source link

Better User Experience for Login Workflow. #72

Closed thertzelle closed 7 years ago

thertzelle commented 7 years ago

This PR adjusts the workflow for an incorrect password, giving a better User Experience for users that mistype their passwords, further more, it helps users return to re-enter their password and allows adjustments for incorrectly typed usernames with a Shift + Tab functionality. This PR also adjusts the password workflow such that it no longer spams the login services with incorrect credentials when users press enter again after the wrong credentials are provided.

Commonly users mistype their password, especially if the passwords are "secure", sometimes fat-fingers happen. (I'll admit I enter my password wrong quite commonly into FreeSO for some reason).

Further more, the way the dialog system was presenting the error messages was on top of the UILoginScreen, so every time a user pressed enter after a wrong password, it would continue to spam the login servers with the wrong credentials.

If the users password is not wrong, maybe the enter their username incorrectly, most users are accustom to being able to press Shift + Tab to return to the previous textfield, FreeSO supported tab into the next field, so adding ShiftTab was relatively straight forward for the Login Dialog.

Thank you for reviewing this PR.

thertzelle commented 7 years ago

I'm not sure why my previous two commits are showing up in this PR, if this could cause problems please reject the PR with that for the reason and I'll find a way to fix my fork.

Thank you.

gmoben commented 7 years ago

@thertzelle Looks like your previous PR was squash merged. This one will probably be as well, so it won't matter unless you'd like a clean commit history. In the future, I'd recommend working on a separate branch for each PR/feature you plan to submit.