search

ripgarpr / garpr

the revival of GarPR. may gar rest in RIP
17 stars 14 forks source link

write smashgg importer #19

Closed jessemtso closed 8 years ago

jessemtso commented 8 years ago

lol "scraper"

BrandonCookeDev commented 8 years ago

Created a 'scraper' for smash gg.

-def get_matches sends back MatchResult model objects as expected

-Also class can populate lists of more detailed SmashGGPlayer and SmashGGMatch objects if so desired. These subclasses aggregate any additional data from the smashgg dump that could prove beneficial in the future.

Test suite contains two tests for each function. 16 tests in total. May need more tests including functions found in the MatchResult model.

Creating a PR for this now.

jessemtso commented 8 years ago

@BrandonCookeDev reminder, create a PR for this when its ready

BrandonCookeDev commented 8 years ago

I was going to ask in slack @jessemtso am I PR into Gar's master or into @yedi 's?

jessemtso commented 8 years ago

into yedis. gar’s is over. yedis is the master now

On Jun 10, 2016, at 3:57 PM, Brandon cookiE notifications@github.com wrote:

I was going to ask in slack @jessemtso https://github.com/jessemtso am I PR into Gar's master or into @yedi https://github.com/yedi 's?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yedi/garpr/issues/19#issuecomment-225280471, or mute the thread https://github.com/notifications/unsubscribe/AGGxsk5oa3cHpu-siL7COwxBhMgs1ZzEks5qKcHAgaJpZM4IuOFA.

BrandonCookeDev commented 8 years ago

Got it, I assumed it was Yedi's so I went ahead and did that. If i was wrong we could fix it later but looks like we're good!

jessemtso commented 8 years ago

closed by https://github.com/ripgarpr/garpr/pull/32