search

ripgarpr / garpr

the revival of GarPR. may gar rest in RIP
17 stars 14 forks source link

Implement SmashGG Error Handling #37

Closed BrandonCookeDev closed 8 years ago

BrandonCookeDev commented 8 years ago

Due to the recent discovery of instability in the SmashGG api (likely due to new releases), the SmashGG importer module needs better error handling in case updates like these will continue to be an issue.

BrandonCookeDev commented 8 years ago

@jessemtso Added an important try catch in the SmashGG branch if you are able to quick-merge without a huge PR.

jhertz commented 8 years ago

Open a PR please

Sent from my iPhone

On Jun 15, 2016, at 8:59 AM, Brandon cookiE notifications@github.com wrote:

@jessemtso Added an important try catch in the SmashGG branch if you are able to quick-merge without a huge PR.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jessemtso commented 8 years ago

fixed w/ https://github.com/ripgarpr/garpr/commit/16993eefa4ea20ce8f2d3067d7a397d3fe499167