search

ripgarpr / garpr

the revival of GarPR. may gar rest in RIP
17 stars 14 forks source link

SmashGG scraper not working correctly on some tournaments #65

Closed jschnei closed 8 years ago

jschnei commented 8 years ago

The SmashGG scraper doesn't seem to be correctly getting the player names for some tournaments. In particular, the list of player tags sometimes has duplicates for some tags and is entirely missing others.

For example, displaying the players in https://smash.gg/tournament/tiger-smash-4/brackets/11097/21317/70949, we get the list of players:

<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c4d0> Druggedfox
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c310> SmashBob SquarePants
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c650> ESAM
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c610> KPAN
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c9d0> Milkman
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c250> stingers
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c850> DAB
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c8d0> NIX
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c950> Trix
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c490> SmashBob SquarePants
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c550> dansofree
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c290> Landry
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c2d0> Wei
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed366c510> loverboy
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed3548510> Spinjump
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed3548490> 92Greatness
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed3548390> Gato
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed35483d0> Perthro
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed3548410> dansofree
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed3548450> DarkLava
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed35484d0> Cohenski
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed3548550> Matchu
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed3548350> DAB
<scraper.smashgg.SmashGGPlayer object at 0x7f0ed3548650> NIX

which contains "SmashBob SquarePants" twice and doesn't contain "One Falcon Punch Man" at all. This issue also comes up in the bracket https://smash.gg/tournament/super-nebulous-4/brackets/11335/14961/50953.

@BrandonCookeDev @VestboyMyst

BrandonCookeDev commented 8 years ago

Looking at it now

BrandonCookeDev commented 8 years ago

Refactored code to get rid of duplicates and be more accurate in general. PR #67 Pending @jhertz

BrandonCookeDev commented 8 years ago

@jschnei I believe the recent PR closes this issue?

jschnei commented 8 years ago

Yeah, #67 closes this.