Open kyzh opened 11 years ago
On the top right one can see the source or graphite url. While i think it is a nice feature, i would like to be able to disable it contains a private API key.
So far here is what i think needs to be done to enable that feature:
I though about a boolean set in the config: https://gist.github.com/kyzh/5507659#file-gdash-yaml-L12
Ensure that the parameter get a default value https://gist.github.com/kyzh/5507714#file-sinatra_app-rb-L34
Pass the variable to the erb template like so: https://gist.github.com/kyzh/5508055#file-sinatra_app-rb-L2 ( https://github.com/ripienaar/gdash/blob/master/lib/gdash/sinatra_app.rb#L234 )
Then display the source URL if graphite_url_displayed is set to true: https://gist.github.com/kyzh/5507792#file-dashboard-erb-L8
Is is a good/bad idea? Is it the right way to go about it? I would be keen to have your feedback on it
Note: It all done in my browser, so it is not tested yet whatsoever.
On the top right one can see the source or graphite url. While i think it is a nice feature, i would like to be able to disable it contains a private API key.
So far here is what i think needs to be done to enable that feature:
I though about a boolean set in the config: https://gist.github.com/kyzh/5507659#file-gdash-yaml-L12
Ensure that the parameter get a default value https://gist.github.com/kyzh/5507714#file-sinatra_app-rb-L34
Pass the variable to the erb template like so: https://gist.github.com/kyzh/5508055#file-sinatra_app-rb-L2 ( https://github.com/ripienaar/gdash/blob/master/lib/gdash/sinatra_app.rb#L234 )
Then display the source URL if graphite_url_displayed is set to true: https://gist.github.com/kyzh/5507792#file-dashboard-erb-L8
Is is a good/bad idea? Is it the right way to go about it? I would be keen to have your feedback on it
Note: It all done in my browser, so it is not tested yet whatsoever.