search

ripienaar / gdash

A dashboard for Graphite
http://www.devco.net/
Apache License 2.0
755 stars 117 forks source link

convert to bootstrap thumbnails rather than rows when displaying images #86

Closed bwhaley closed 11 years ago

bwhaley commented 11 years ago

This PR fixes issue #85. It also switches from using Bootstrap rows to strictly thumbnails, which I think it more appropriate for an image grid. Anyone care to review this?

bwhaley commented 11 years ago

Woops, did not mean to close it.

keymon commented 11 years ago

Works for me +1

falkenbt commented 11 years ago

actually... @bwhaley how do you define the image sizes now? The height/width settings in gdash.yaml or dash.yaml have no effect anymore because bootstraps span4 size is fixed. Or am I missing something?

bwhaley commented 11 years ago

Adjusting graph_width and graph_height in gdash.yaml is working for me in all views.

800x500 800x500

500x250 500x250

bwhaley commented 11 years ago

Hmm but I see your point, the image is the right size but pixel # is constrained by the span. I will poke at this later.

toerkl commented 11 years ago

Very interested in knowing how to have different sizes for different views. Detailed and thumbnail grid. If anyone could explain or show me documentation of how to do it it would be great

bwhaley commented 11 years ago

@lindqt01 You can specify ?width=X&height=Y in your URL to change the size of the graph. Does that help?

toerkl commented 11 years ago

@bwhaley After clicking on one of the graphs you get a detailed view with default time intervals. I would like to have those graphs bigger and maybe less amount of columns. Is this possible to achieve with templates or do i need to go into the code for that?

bwhaley commented 11 years ago

@falkenbt I fixed this in bwhaley/gdash@4f4bfb705153aaea8a6fccfaec958f515dcc07c6 by reverting to a table format and using container-fluid in the layout. This branch also fixes an issue in graph.erb where query parameters were not passed on to the detailed dashboard.

bwhaley commented 11 years ago

@lindqt01 The graphs can be bigger by appending width=N&height=M in the query parameters (after this fix is merged, that is). There is currently no way to dynamically adjust the number of columns.