search

ripienaar / gdash

A dashboard for Graphite
http://www.devco.net/
Apache License 2.0
755 stars 117 forks source link

Use browser's timezone for default tz when rendering graph #89

Closed wpc closed 11 years ago

wpc commented 11 years ago

This is quite important for a distributed team like mine. We have half of team in London and half in San Francisco. So we can not hard code a timezone into gdash configuration of graphite configuration.

falkenbt commented 11 years ago

I would also rather have it in the controller. I'm not sure if a default to browser time zone is a good idea because you can also configure a default in graphite.

For me it would make more sense to use the graphite default and optionally the browser timezone. In our use-case, I prefer the default graphite timezone match as the servers' tz that are under monitoring in order to correlate log-events to graphite data easily.

How about a timezone picker / input form in the UI so one can easily switch between timezones (and store the tz for the session)? We could probably extend the timepicker from https://github.com/ripienaar/gdash/pull/65 for this?

keymon commented 11 years ago

That can be more or less easily being done using the placeholders ?p[timezone]=CEThttp://graphite.example.net:3000/category_name/dash_name/?p%5Bnode%5D=node.example.net

http://gdash.server.net/category_name/dash_name/?p[timezone]=CEThttp://graphite.example.net:3000/category_name/dash_name/?p%5Bnode%5D=node.example.net

Then, in your .graph you can use something like:

timezone = @properties[:timezone] if @properties[:timezone]

Héctor Rivas

On Mon, Mar 25, 2013 at 12:37 PM, falkenbt notifications@github.com wrote:

I would also rather have it in the controller. I'm not sure if a default to browser time zone is a good idea because you can also configure a default in graphite.

For me it would make more sense to use the graphite default and optionally\ the browser timezone. In our use-case, I prefer the default graphite timezone match as the servers' tz that are under monitoring in order to correlate log-events to graphite data easily.

How about a timezone picker / input form in the UI so one can easily switch between timezones (and store the tz for the session)? We could probably extend the timepicker from #65https://github.com/ripienaar/gdash/issues/65for this?

— Reply to this email directly or view it on GitHubhttps://github.com/ripienaar/gdash/pull/89#issuecomment-15390695 .

wpc commented 11 years ago

A sticky timezone picker like falkenbt suggested sounds like a good idea. Please feel free to close this request without merging.