ripienaar / travlrmap

Sinatra based travels map
Other
13 stars 2 forks source link

add ability to rely on Web server basic authentication for geocode #48

Closed doc75 closed 9 years ago

doc75 commented 9 years ago

This patch add a new option in map: allow_webserver_authent If it is set to true, then we check if environment variable REMOTE_USER is set. It is is set, then we consider that we are authenticated.

It avoids infinite loop when installing travlramp behing an Apache basic authentication.

PS: I did not find where it is possible to edit the site 'https://ripienaar.github.io/travlrmap/' to add the new option. Let me know if I missed something.

doc75 commented 9 years ago

Please note that this patch does not check that the user is the admin user. I will try to enhance it asap. But need some more test to make sure it runs properly in most cases. It should check that user is admin and raise 'Not authorized' if not

ripienaar commented 9 years ago

Hey

Would we even make this an option? When authenticating just check that the variable is set if not fall back to doing own auth?

Am on the road I think it should be doable and can review code later this week

The web page is in a branch gh-pages in the same repo :)

Thanks for the commit will review soon


R.I.Pienaar

On 16 Feb 2015, at 11:22, doc75 notifications@github.com wrote:

Please note that this patch does not check that the user is the admin user. I will try to enhance it asap. But need some more test to make sure it runs properly in most cases. It should check that user is admin and raise 'Not authorized' if not

— Reply to this email directly or view it on GitHub.

ripienaar commented 9 years ago

I made #49 and there's a commit https://github.com/ripienaar/travlrmap/commit/cdfc95428015c3c881dce583fb56fbc32e9e0458 that might sort this out quite easily?

Mind checking it does what you want? You just need to set :admin_user to match what your webserver does, no need for admin_salt or admin_hash then

ripienaar commented 9 years ago

Updated that comment a few times - correct commit is https://github.com/ripienaar/travlrmap/commit/cdfc95428015c3c881dce583fb56fbc32e9e0458

doc75 commented 9 years ago

I close this pull request as better code provided in #49. Thanks.