ripmeapp2 / ripme

Downloads albums in bulk

MIT License

302 stars 38 forks source link

Update ImgboxRipper to set album title for folder #150

Closed pesho1323 closed 12 months ago

pesho1323 commented 12 months ago

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[x] a bug fix (Fix #136 ) Not exactly a bug as it was never implemented but yes..
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix
[x] a new feature

Description

Implemented the getAlbumTitle() method in ImgboxRipper to set album title for folder if it can get it and not use id by default. If the album title could not be fetched we fallback to the id. Kept the "imgbox_" prefix as it is the convention throughout the tool.

Testing

Manual downloading multiple galleries

pesho1323 commented 12 months ago

These changes introduce more issues than they fix, encoding is tricky and does not work in all cases which leads to empty folder names. Closing the PR